Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL for sprintf to reference API docs #29843

Closed
wants to merge 1 commit into from

Conversation

aaemnnosttv
Copy link

Description

Updated the URL referenced in the documentation for the sprintf function in the @wordpress/i18n package.

The current URL seems to be completely unrelated to JS and may even be spam/malicious.

It's a one-line doc change (I assume the main readme does not need this change as well as it's auto-generated from inline docs?)

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@aaemnnosttv aaemnnosttv requested a review from swissspidy as a code owner March 12, 2021 21:23
@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Mar 12, 2021
@github-actions
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @aaemnnosttv! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@swissspidy
Copy link
Member

Duplicate of #29699

@swissspidy swissspidy marked this as a duplicate of #29699 Mar 12, 2021
@talldan
Copy link
Contributor

talldan commented Mar 15, 2021

Thanks for working on this, appreciate the proactiveness of fixing something you noticed was broken. I went ahead and merged the other PR, so will close this now.

@talldan talldan closed this Mar 15, 2021
@aaemnnosttv aaemnnosttv deleted the patch-1 branch March 15, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants